Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer fetched version when determining HPA group version kind #22840

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Prefer fetched version when determining HPA group version kind #22840

merged 1 commit into from
Mar 11, 2016

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 11, 2016

Related to #22484 for kubectl get <type> list cases

@liggitt liggitt mentioned this pull request Mar 11, 2016
Closed
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2016
@liggitt liggitt force-pushed the preferred-gvk branch 2 times, most recently from 4ca83f5 to 86da6a1 Compare March 11, 2016 05:02
@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 17e24ab80188de9625d8aa24af16c31e66f5f7dc.

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 560b02b.

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 86da6a1cb51fd3c7e6fd2ebd540a4c9670ba6517.

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

We should look closely at other InfoForObject() calls as well and see if we can pass meaningful preferredGVKs. We should return an error if we cant rather than silently choosing a random one.
This is strictly better than the current state since it atleast fixes kubectl get.

@nikhiljindal nikhiljindal added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 11, 2016
@nikhiljindal
Copy link
Contributor

cc @deads2k

@liggitt
Copy link
Member Author

liggitt commented Mar 11, 2016

agree that it doesn't close #22484

@bgrant0607 bgrant0607 added this to the v1.2 milestone Mar 11, 2016
@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
@bgrant0607
Copy link
Member

Manually merging.

bgrant0607 added a commit that referenced this pull request Mar 11, 2016
@bgrant0607
Merge pull request #22840 from liggitt/preferred-gvk
e5748a4 
Prefer fetched version when determining HPA group version kind
@bgrant0607 bgrant0607 merged commit e5748a4 into kubernetes:master Mar 11, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22840 from liggitt/preferred-gvk
cfee56a 
Prefer fetched version when determining HPA group version kind
@eparis eparis mentioned this pull request Mar 11, 2016
Merged
@liggitt liggitt deleted the preferred-gvk branch March 11, 2016 16:39
@nikhiljindal nikhiljindal mentioned this pull request Mar 11, 2016
Closed
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR was sucessfully cherry picked in PR #22855
please verify that the release-1.2 branch contains these changes as you would expect and contact @eparis if there appear to be problems.

@eparis eparis removed cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@bgrant0607 @eparis
Merge pull request kubernetes#22840 from liggitt/preferred-gvk
26df6c6 
Prefer fetched version when determining HPA group version kind
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@bgrant0607 @eparis
Merge pull request kubernetes#22840 from liggitt/preferred-gvk
0680ec7 
Prefer fetched version when determining HPA group version kind
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request May 29, 2019
@k8s-publishing-bot
Merge pull request kubernetes#22840 from openshift-cherrypick-robot/c…
164f8a4 
…herry-pick-22834-to-release-4.1

Bug 1694087: Do not reset container state when pod is deleted

Origin-commit: d21f2fc661f57e39919c13a0ec5c739afc6f1b08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liggitt @k8s-github-robot @k8s-bot @nikhiljindal @bgrant0607 @eparis @k8s-teamcity-mesosphere @smarterclayton @googlebot